Skip to content

Conversation

@vladmihalcea
Copy link
Contributor

@vladmihalcea
Copy link
Contributor Author

@sebersole @dreab8 If you have time, can you take a look at this optimization. It's a very useful addition to the Hibernate Types project.

@NathanQingyangXu
Copy link
Contributor

I think a more elegant way to get access to other stuff than configuration map is to add something into TypeBootstrapContext as following:

public interface TypeBootstrapContext {
	Map<String, Object> getConfigurationSettings();
        ServiceRegistry getServiceRegistry();
}

This way we don't need to make our magic overcomplicated and it is much easier to extend (simply adding new stuff into TypeBootstrapContext.

@vladmihalcea
Copy link
Contributor Author

@NathanQingyangXu That would not work for my use case. Because the TypeBootstrapContext class is only available in newer HIbernate 5.4 versions, I'll get a class loading error on Hibernate 5.2, 5.3, or previous 5.4 versions if the Hibernate Types project adds such a constructor to its Types.

That's why I proposed this change. In fact, that should have been the first option as the TypeBootstrapContext didn't help.

@NathanQingyangXu
Copy link
Contributor

NathanQingyangXu commented Sep 4, 2020 via email

@gavinking
Copy link
Member

superseded by #9313

@gavinking gavinking closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants